]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
grabHelper: Correct typo preventing focus-window-changed disconnect
authorJasper St. Pierre <jstpierre@mecheye.net>
Sat, 16 Feb 2013 17:44:04 +0000 (12:44 -0500)
committerJasper St. Pierre <jstpierre@mecheye.net>
Sat, 16 Feb 2013 18:33:45 +0000 (13:33 -0500)
While debugging, I found that the signal to focus-window-changed
was never getting disconnected, making a call to ungrab every time
the focus window changed, even if there were no focus grabs anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=693975

js/ui/grabHelper.js

index 0c0e190d5e48a89158542eeb7dee3a627a075318..058524ae8a3eb4a35073f4b06e1e8730e9ba40e1 100644 (file)
@@ -232,7 +232,7 @@ const GrabHelper = new Lang.Class({
             this._keyFocusNotifyId = 0;
         }
 
-        if (!this._focusWindowChanged > 0) {
+        if (this._focusWindowChangedId > 0) {
             let metaDisplay = global.screen.get_display();
             metaDisplay.disconnect(this._focusWindowChangedId);
             this._focusWindowChangedId = 0;